feat: create script for omit package.json fields before publish #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easymikey
changed the title
easymikey
changed the title
antongolub
requested changes
Dec 18, 2024
antongolub
requested changes
Dec 18, 2024
antongolub
requested changes
Dec 18, 2024
test/it/clean-package-json.test.js
Outdated
| it('handle exist properties required for publishing', async () => { | ||
| await t$`node scripts/clean-package-json.mjs` | ||
| // to throw if manifest is not correct | ||
| const file = createRequire(import.meta.url)( |
There was a problem hiding this comment.
fs.readFileSync + JSON.parse
test/it/clean-package-json.test.js
Outdated
| const file = createRequire(import.meta.url)( | ||
| path.resolve(tmp, 'package.json') | ||
| ) | ||
| assert.strictEqual(whitelist, Object.keys(file)) |
There was a problem hiding this comment.
assert.equal(pkgJson.name, 'zx')
assert.equal(pkgJson.prettier, undefined)
|
I call the tests and my files are deleted. Is this how it should be?
|
$ fnm use 22
Using Node v22.10.0
$ node -e "console.log(require('fs').glob)"
[Function: glob]
$ fnm use 20
Using Node v20.11.1
$ node -e "console.log(require('fs').glob)"
undefined |
antongolub
requested changes
Dec 18, 2024
test/it/clean-package-json.test.js
Outdated
|
|
||
| const __dirname = path.dirname(new URL(import.meta.url).pathname) | ||
| const root = path.resolve(__dirname, '../../') | ||
| const whitelist = [ |
There was a problem hiding this comment.
This const is redundant now.
There was a problem hiding this comment.
Are you suggesting to completely remove the check for fields, since they are in the script?
easymikey
force-pushed
the
omit-package-json-field-before-npm-publish
branch
from
c4a0935 to
5e059cd
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create script and test
Fixes #1003