Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Option in side table creation #718

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

zhouwfang
Copy link
Member

#46

- remove Option
- apply new() directly instead of using another for loop
@zhouwfang zhouwfang requested a review from ia0 as a code owner January 7, 2025 05:02
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but instead of removing the checks, I would move them to debug-mode only.

crates/interpreter/src/valid.rs Show resolved Hide resolved
crates/interpreter/src/valid.rs Show resolved Hide resolved
@zhouwfang zhouwfang changed the title Remove a for loop in side table creation Save a for loop in side table creation Jan 7, 2025
@zhouwfang zhouwfang changed the title Save a for loop in side table creation Remove Option in side table creation Jan 8, 2025
@zhouwfang zhouwfang requested a review from ia0 January 8, 2025 00:08
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

crates/interpreter/src/valid.rs Show resolved Hide resolved
@ia0 ia0 merged commit 009a15d into google:dev/fast-interp Jan 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants