Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize side table masks #713

Merged
merged 16 commits into from
Jan 3, 2025
Merged

Conversation

zhouwfang
Copy link
Member

@zhouwfang zhouwfang commented Jan 2, 2025

Based on experiments, these are the smallest masks to pass CI. In other words, SideTableEntry only requires u35 at this point. I'll add the fields from func_type() and func() in module.rs to the side table in #711, and SideTableEntry as u64 might not be sufficient.

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner January 2, 2025 23:50
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's most probably too strict on the counts. I think we should eventually end up with:

  • 16 bits delta IP
  • 16 bits delta STP
  • 4 bits val count
  • 12 bits pop count

This gives 48 bits aligned on 16 bits.

@ia0 ia0 merged commit b9de9e9 into google:dev/fast-interp Jan 3, 2025
20 checks passed
@zhouwfang zhouwfang deleted the optimize-masks branch January 4, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants