Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment delta_stp by 1 for "if with else" in validation #700

Merged

Conversation

zhouwfang
Copy link
Member

@zhouwfang zhouwfang commented Dec 5, 2024

When "if" has an "else", we should skip the entry for "else" in the side table. It was addressed in #690 during execution and should be moved to validation.

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner December 5, 2024 06:20
@zhouwfang zhouwfang changed the title Increment delta_stp for "if with else" in validation Increment delta_stp by 1 for "if with else" in validation Dec 5, 2024
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
@zhouwfang zhouwfang force-pushed the fix-delta-stp-for-if-with-else branch from 8b645b4 to 0deda4d Compare December 5, 2024 20:31
@zhouwfang zhouwfang requested a review from ia0 December 5, 2024 20:31
@ia0 ia0 merged commit a3d58dc into google:dev/fast-interp Dec 6, 2024
20 checks passed
@zhouwfang zhouwfang deleted the fix-delta-stp-for-if-with-else branch December 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants