You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The output of maktaba#path#MakeRelative doesn't have a trailing slash even if the {path} argument had one: maktaba#path#MakeRelative('/foo', '/foo/bar/') → 'bar'
Since trailing slashes are significant in maktaba's path handling, explicitly signifying a directory path instead of a file path, it would be better to preserve any trailing slash from input to output.
The text was updated successfully, but these errors were encountered:
Apparently this is just a manifestation of #137 since it's a call to maktaba#path#Split in the MakeRelative implementation that's losing the trailing slash.
Changes since 1.14.0:
* Implement maktaba#buffer#GetVisualSelection helper (#132).
* Implement maktaba#log#GetFormattedEntries and support 1-arg log
handler (see #204).
* Notify user for messages logged at WARN or above by default (#185).
* Fix Syscall.CallAsync failing for complex commands (#205).
* Preserve trailing slash in maktaba#path#Split and MakeRelative
(#137 and #175).
* Fix 'maxfuncdepth' error in maktaba#json#Parse corner case (#153).
The output of
maktaba#path#MakeRelative
doesn't have a trailing slash even if the{path}
argument had one:maktaba#path#MakeRelative('/foo', '/foo/bar/')
→'bar'
Since trailing slashes are significant in maktaba's path handling, explicitly signifying a directory path instead of a file path, it would be better to preserve any trailing slash from input to output.
The text was updated successfully, but these errors were encountered: