Some general Vector4 optimizations #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccutchan
approved these changes
May 31, 2023
|
What is going on with the code coverage? That is a steep drop. |
That is very strange... Are you sure the coveralls check ran properly? |
|
Just reran for giggles. It seems coverage fell off a cliff before this change. Maybe rebase on master? |
It has the same coverage percentage on master now 🤷♂️ |
spydon
force-pushed
the
fix/vector4
branch
2 times, most recently
from
78fbb96
to
102efd5
Compare
johnmccutchan
approved these changes
Jul 19, 2023
spydon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
Vector4.zeroconstructor was already a normal named constructor it was already possible to extend the class.Converts all factory constructors (exceptVector4.random) to named constructors that directly sets the storage instead of calling intermediary methods to do it.length2,dot,isInfiniteandisNaN.reflect,relativeErrorandabsoluteErrorso that they don't create extraVector4objects._v4storagefrom 1 to 0 so that it is consistent across the class and guarantees that bounds checking is only done once.