Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate classes in Truth 0.41 #467

Closed
madisp opened this issue Jun 18, 2018 · 3 comments
Closed

Duplicate classes in Truth 0.41 #467

madisp opened this issue Jun 18, 2018 · 3 comments
Milestone
0.42

Comments

@madisp
Copy link

madisp commented Jun 18, 2018

Truth pulls in both org.checkerframework:checker-compat-qual and org.checkerframework:checker-qual.

Both artifacts contain some classes, like org.checkerframework.checker.formatter.FormatUtil - typetools/checker-framework#712

This breaks Android builds :/ Workaround is to go back to 0.40
@madisp
Copy link
Author

madisp commented Jun 18, 2018

Alternative workaround is to exclude checker-qual:

  androidTestImplementation('com.google.truth:truth:0.41') {
    exclude group: 'org.checkerframework', module: 'checker-qual'
  }

@cpovirk
Copy link
Member

cpovirk commented Jun 18, 2018

Thanks for the report. It looks like upgrading to org.checkerframework:checker-compat-qual and org.checkerframework:checker-qual to 2.5.2 probably also does the trick? You could force that override locally, but I'm going to make the change in Truth and Guava, too, for the next release.

cgdecker pushed a commit that referenced this issue Jun 28, 2018
@cpovirk @cgdecker
Bump Checker Framework annotations version to 2.5.2.
af5597e 
Fixes #467 for Truth and perhaps similar problems for other projects that use Guava.

RELNOTES: Updated to versions of the Checker Framework annotations packages that don't contain conflicting classes.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201097814
cgdecker pushed a commit to google/guava that referenced this issue Jun 28, 2018
@cpovirk @cgdecker
Bump Checker Framework annotations version to 2.5.2.
2dc37da 
Fixes google/truth#467 for Truth and perhaps similar problems for other projects that use Guava.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201097814
cgdecker pushed a commit to google/guava that referenced this issue Jun 28, 2018
@cpovirk @cgdecker
Bump Checker Framework annotations version to 2.5.2.
7a6a971 
Fixes google/truth#467 for Truth and perhaps similar problems for other projects that use Guava.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=201097814
@gabrielittner gabrielittner mentioned this issue Jul 6, 2018
Closed
@cpovirk cpovirk added this to the 0.42 milestone Jul 12, 2018
@cpovirk
Copy link
Member

cpovirk commented Jul 12, 2018

Truth fix released in Truth 0.42... but we may need a Guava release (possibly coming on Wednesday?) and then an update for Truth to use that for the problem to fully go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.42
Development

No branches or pull requests
2 participants
@madisp @cpovirk