Deprecate merkle packages #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
force-pushed
the
annotate_merkle_deprecation
branch
from
3cac284
to
9c4b768
Compare
|
Hmm, I wonder how to silence the self-warnings about deprecated packages using themselves. |
|
There must be some "silencing" annotations for golangci linter. |
pav-kv
force-pushed
the
annotate_merkle_deprecation
branch
from
c3a042c
to
dbd34c1
Compare
jiggoha
reviewed
Apr 22, 2022
jiggoha
reviewed
Apr 22, 2022
|
@jiggoha It's ok to annotate only one file per package, because the package comments are "global" within package. So, a single comment in one file deprecates the entire package. |
jiggoha
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trillian is using https://github.com/transparency-dev/merkle. The
merklepackagesin Trillian will be removed in next releases.
Part of #2338.
Checklist