Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the GetLeavesByIndex method from the log storage interface. #2426

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Remove the GetLeavesByIndex method from the log storage interface. #2426

merged 1 commit into from
Mar 23, 2021

Conversation

pphaneuf
Copy link
Contributor

Part of #2245.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2426 (c7ae35a) into master (ab61c60) will increase coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
+ Coverage   65.17%   65.74%   +0.57%     
==========================================
  Files         104      104              
  Lines        7412     7299     -113     
==========================================
- Hits         4831     4799      -32     
+ Misses       2063     1990      -73     
+ Partials      518      510       -8     
Impacted Files Coverage Δ
storage/cloudspanner/log_storage.go 55.76% <ø> (+5.85%) ⬆️
storage/memory/log_storage.go 3.61% <ø> (+0.10%) ⬆️
storage/mysql/log_storage.go 66.12% <ø> (+0.64%) ⬆️
storage/tools/dump_tree/dumplib.go 41.35% <0.00%> (ø)
log/operation_manager.go 87.30% <0.00%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab61c60...c7ae35a. Read the comment docs.

@pphaneuf pphaneuf marked this pull request as ready for review March 23, 2021 10:47
@pphaneuf pphaneuf requested a review from a team as a code owner March 23, 2021 10:47
@pphaneuf pphaneuf requested review from getagit, AlCutter and pav-kv March 23, 2021 10:47
@pphaneuf pphaneuf merged commit bb6b437 into google:master Mar 23, 2021
@pphaneuf pphaneuf deleted the remove_storage_getleavesbyindex branch March 23, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants