Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloud Spanner support. #2423

Closed
wants to merge 1 commit into from
Closed

Remove Cloud Spanner support. #2423

wants to merge 1 commit into from

Conversation

pphaneuf
Copy link
Contributor

Part of #2245.

@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2423 (e6b2e54) into master (eaad43e) will increase coverage by 3.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
+ Coverage   65.95%   69.92%   +3.96%     
==========================================
  Files         104       99       -5     
  Lines        7273     6094    -1179     
==========================================
- Hits         4797     4261     -536     
+ Misses       1966     1429     -537     
+ Partials      510      404     -106     
Impacted Files Coverage Δ
log/operation_manager.go 88.35% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaad43e...e6b2e54. Read the comment docs.

@pphaneuf pphaneuf requested a review from pav-kv March 22, 2021 17:39
@pphaneuf pphaneuf marked this pull request as ready for review March 22, 2021 17:40
@pphaneuf pphaneuf requested a review from a team as a code owner March 22, 2021 17:40
@pphaneuf pphaneuf requested a review from AlCutter March 22, 2021 17:40
@pav-kv
Copy link
Contributor

pav-kv commented Mar 23, 2021

I remember from @AlCutter that we run some internal CloudSpanner instance. Defer the review to Al.

@pphaneuf
Copy link
Contributor Author

Sure thing. I think we've stopped using that instance, but should get confirmed, @AlCutter should know.

@AlCutter
Copy link
Member

The CI/CD instance uses CloudSpanner

@pphaneuf
Copy link
Contributor Author

Seems that we're using it for some post-submit testing, so we'll keep it.

@pphaneuf pphaneuf closed this Mar 24, 2021
@pphaneuf pphaneuf deleted the cloudspanner branch March 24, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants