Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resend original SCT if a client submits a certificate that already exists in the log #415

Closed
jcao219 opened this issue Mar 6, 2017 · 1 comment
Closed

Resend original SCT if a client submits a certificate that already exists in the log #415

jcao219 opened this issue Mar 6, 2017 · 1 comment
Assignees
@daviddrysdale

Comments

@jcao219
Copy link

jcao219 commented Mar 6, 2017

Currently, if a client sends the same certificate twice, on the second time, it will fail with AddChain handler error: backend QueueLeaves request failed: rpc error: code = AlreadyExists desc = Leaf hash already exists due to https://github.com/google/trillian/blob/master/examples/ct/handlers.go#L308.

To comply with the RFC, any valid submission must yield an SCT.
@daviddrysdale daviddrysdale self-assigned this Mar 6, 2017
@daviddrysdale
Copy link
Contributor

Fixed by #421

gdbelvin added a commit to gdbelvin/trillian that referenced this issue Dec 5, 2017
@gdbelvin
Squashed 'vendor/github.com/grpc-ecosystem/grpc-gateway/' changes fro…
9b9114a 
…m 589b12611..55c1d0c85

8cc3a55af Add custom options to allow more control of swagger/openapi output (google#145)
b0be3cdef runtime: fix chunk encoding
82b83c781 protoc-gen-swagger optional SourceCodeInfo
1fd8ba6a5 Fix logic handling primitive wrapper in URL params
b2423da79 runtime: use r.Context() (google#473)
c323909dd Add Handler method to pass in a client (google#454)
ac41185c3 Fallback to JSON name when matching URL parameter. (google#450)
8bec008bd fix 2 typos in Registry.SetPrefix's comment
de5a00fcc Reference Gulp by a more complete path
185dda2d4 Fix build.
824b9a716 Test with Go 1.9.
f2862b476 Memoise calls to fullyQualifiedNameToSwaggerName to speed it up for large registries (google#421)
1a03ca3ba Update DO NOT EDIT template. (google#434)
a5c7982c0 Update Swagger Codegen from 2.1.6 to 2.2.2 (google#415)
d64f5319e ISSUE#405: customize the error return (google#409)
c6f7a5ac6 improve {incoming,outgoing}HeaderMatcher logic (google#408)
2a40dd795 Return if runtime.AnnotateContext gave error (google#403)
47a11d786 jsonpb: update tests to reflect new jsonpb behavior (google#401)
f6f92fcd9 Reference import grpc Status to suppress unused errors. (google#387)
979be44d9 fixes package name override doesn't work (google#277)
b1e4aed16 Skip unreferenced messages in definitions. (google#371)
ca4c8d6af ci: regen with current protoc-gen-go (google#385)
7195ea445 Use status package for error and introduce WithProtoErrorHandler option (google#378)
4539fc575 Add response headers from grpc server (google#374)
597c8c358 support allow_delete_body for protoc-gen-grpc-gateway (google#318)
55d0969c0 Use canonical header form in default header matcher. (google#369)
893772d22 Extend ServeMux to allow user configurable header forwarding.

git-subtree-dir: vendor/github.com/grpc-ecosystem/grpc-gateway
git-subtree-split: 55c1d0c857e5c6cadb0ee292f6cc36621cd5ea8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviddrysdale daviddrysdale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcao219 @daviddrysdale