Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology change: "service date" -> "service day" #45

Merged
merged 3 commits into from
Feb 7, 2017

Conversation

antrim
Copy link
Contributor

@antrim antrim commented Jan 27, 2017

This change is to make the Specification reference more consistent with common transit terminology. See issue #43 for further discussion.

@antrim
Copy link
Contributor Author

antrim commented Jan 27, 2017

It looks as though there is support for this change (see discussion in issue #43). Let's start the 7 day voting period for this change, unless anyone has other comments. So that there are 7 full calendar days, then the vote would end on Friday, February 3 @ 23:59:59 UTC.

Note that pull request #44 (open for voting) also uses the term "service day".

@barbeau
Copy link
Collaborator

barbeau commented Jan 27, 2017

+1 - can you announce on gtfs-changes and cross link both?

@RachM
Copy link
Contributor

RachM commented Jan 29, 2017

+1

1 similar comment
@abyrd
Copy link

abyrd commented Jan 30, 2017

+1

@antrim
Copy link
Contributor Author

antrim commented Feb 4, 2017

The voting period has ended. It looks as though there is support for this change. @zhsh: Can you please merge and close?

@dbabramov dbabramov merged commit ebc6b53 into google:master Feb 7, 2017
@dbabramov dbabramov added the GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule label Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants