-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTFS Trip-Modifications #403
Merged
eliasmbd
merged 42 commits into
google:master
from
TransitApp:gtfsrt/trip_modifications
Mar 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
b2bfcf5
Add Trip-Modification, make shape non-experimental
gcamp ab5e996
Create a page for TripModifications entities for consistency with TU …
npaun 7887381
Clarify providing TUs for modified trips and ReplacementStop time int…
npaun da1c109
Merge remote-tracking branch 'google/master' into gtfsrt/trip_modific…
gcamp 52d4064
Fix first_stop_reference.png not having the right image + optimize im…
gcamp c2f88a0
Fix optional/require for Stop message
gcamp 9a0d6d5
Clarify behaviour and linkage to TripUpdates
gcamp 7a67845
Apply Modification clarification proposed changes
gcamp 364e32b
Use ModifiedTripSelector instead of concatenation of IDs
gcamp f3944b0
Add details on behavior when is provided
gcamp 8533985
Remove modifications_id
gcamp 121049c
Merge pull request #12 from TransitApp/feature/trip_modification_sele…
gcamp 4b90e8a
Fix after comments from @bdferris-v2
gcamp 7ef14f5
Add note about producer needed the two versions of trip updates
gcamp 8f5d394
Fix bad relationship mentionned, + force no other entity when using M…
gcamp 0126942
Changes after Jan 10 call
gcamp 429c56b
Merge remote-tracking branch 'google/master' into gtfsrt/trip_modific…
gcamp e0b0f48
Add experimental notices
gcamp 14e4259
Remove mention of stop pattern
gcamp 36f3cac
Use stop selector instead of stop sequence only
gcamp b92a5b2
Update to end_stop_selector
gcamp fb9c8df
Update proto with start/end stop selector
gcamp b5f65bf
Add selected trips
gcamp f26ded5
Update reference with SelectedTrips
gcamp 5e6f44c
Update trip modif doc
gcamp a91db62
Add last_modified_time
gcamp 47a3ceb
Add missing start_times in pb
gcamp 99aba67
Fix typos, fix description of selected trips
gcamp c4e94d9
Fix typos
gcamp 437fc84
Update reference for clarity
gcamp ae77b32
Clarify and remove duplicated information
gcamp 1c54a21
Consistancy
gcamp be4a9c6
Changes before experimental vote
gcamp 51980b8
Revert correctly shape experimental
gcamp 5afb5de
Merge branch 'final/trip_modification' into gtfsrt/trip_modifications
gcamp 2721fe0
Editorial, formatting clarifications
jfabi a1e4af7
Merge pull request #17 from jfabi/gtfsrt/trip_modifications_editorial
gcamp 19b4d2e
Apply suggestions from @sam-hickey-ibigroup
gcamp 37f290d
Update documentation images with new fields, add source files
gcamp 418702a
Clarifies behavior of propagated_modification_delay when no stop_time…
gcamp b437508
Remove extra word
gcamp 4be2666
Sync .proto and reference files
gcamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update proto with start/end stop selector
- Loading branch information
commit fb9c8dff680f9b7a817f8f52d775d7cef2bd0962
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think you are using tab indentation in a few place here where the rest of the file uses spaces? I know it's petty to complain about whitespace in a code-review, but it's making it hard to look at the delta in Github because the indentation is weird 😇 Both here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The indentation looks strange in Github.