Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTFS-rt : wheelchair access update #340

Merged
merged 1 commit into from
Jul 25, 2022
Merged

GTFS-rt : wheelchair access update #340

merged 1 commit into from
Jul 25, 2022

Conversation

flaktack
Copy link
Contributor

@flaktack flaktack commented Jul 6, 2022

This pull request add the ability to specify a wheelchair_accessible value in a TripUpdate.VehicleDescriptor that updates the value found in the static GTFS. Since VehicleDescriptor is shared with VehiclePosition the value may also be specified there.

This pull is intentionally small, it doesn't support all cases of accessibility values and instead relies on what is already accepted in the GTFS.

This is a rebase+squash of #87, along with moving the field to VehicleDescriptor.

@flaktack flaktack mentioned this pull request Jul 6, 2022
Merged
@flaktack
Copy link
Contributor Author

flaktack commented Jul 6, 2022

Producer:

Consumer:

@gcamp
Copy link
Contributor

gcamp commented Jul 6, 2022 •
edited
Loading

Good proposition!

Why not keep the values of the enum the same as in GTFS static? NO_VALUE could be added at the end instead of the beginning. (And yes, I realize I'm commenting on something I proposed myself 😅 ) Read back the original discussion and this comment by @barbeau explains it. All good to me!

Note that Adelaide and TfNSW have extensions that do the same thing without a "NO_VALUE" defined. At Transit we support those extensions and would be happy to support the official version when merged.

@scmcca scmcca added GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime feature labels Jul 6, 2022
@leonardehrenfried
Copy link
Contributor

Seems that we have 3 producers and 2 consumers which was both lacking last time this was proposed.

@BodoMinea
Copy link

As a feed producer for multiple projects contracted to @FlashWebIT, this would be a very useful feature. We're working with multiple bus operators that do not have fully accessible fleets for specific routes, so the information cannot be hardcoded in the static GTFS and the ability to pull that from the vehicle properties and add it to the real-time trip parameters would be the correct way to present this to our consumers.

I am looking forward to this being merged!

@leonardehrenfried
Copy link
Contributor

@flaktack I just re-read the rules about opening a vote on the mailing list. It looks like you as the advocate of the proposal are supposed to send a message to https://groups.google.com/g/gtfs-changes/ to open the vote.

Or can anyone do that?

@flaktack
Copy link
Contributor Author

flaktack commented Jul 13, 2022 •
edited
Loading

per the Specification Amendment Process: 7 days of discussion have passed and it looks like there is consensus. I am now calling a vote 🗳️

Voting ends 2022-07-21 at 23:59:59 UTC.

The mailing list thread is at https://groups.google.com/g/gtfs-realtime/c/wDUl43e44js

@gcamp
Copy link
Contributor

gcamp commented Jul 13, 2022

+1 Transit

@BodoMinea
Copy link

If it wasn't obvious from my previous reply, +1 FlashWeb IT as a producer.

@skinkie
Copy link
Contributor

skinkie commented Jul 13, 2022

+1 OpenGeo

@brodyFlannigan
Copy link

+1 Brody Flannigan Transit Data

@leonardehrenfried
Copy link
Contributor

+1 OpenTripPlanner

@scmcca scmcca added the Status: Voting Pull Requests where the advocate has called for a vote as described in the changes.md label Jul 14, 2022
@hannesj
Copy link

hannesj commented Jul 14, 2022

+1 from Entur

@jfabi
Copy link
Contributor

jfabi commented Jul 19, 2022

+1 from the MBTA

@flaktack
Copy link
Contributor Author

The vote has ended with 7 votes in favor and 0 opposed, with which this PR has passed. Thanks for voting!

@scmcca scmcca removed the Status: Voting Pull Requests where the advocate has called for a vote as described in the changes.md label Jul 25, 2022
@scmcca scmcca merged commit 8993a24 into google:master Jul 25, 2022
omar-kabbani added a commit to MobilityData/transit that referenced this pull request Aug 4, 2022
@omar-kabbani
Squashed commit of the following:
6a4e186 
commit 9d5ebf1
Author: Guillaume Campagna <guillaume.campagna@gmail.com>
Date:   Tue Jul 26 17:09:35 2022 -0400

    Add trip-to-trip transfers with in-seat option (google#303)

    * Add trip-to-trip transfers with in-seat option

    * Fix stop_id are **Conditionally Required** and formatting

    * Add clarification about potential conflict

    * Fix typo

    Co-authored-by: Leonard Ehrenfried <mail@leonard.io>

    Co-authored-by: Nicholas Paun <np@icebergsystems.ca>
    Co-authored-by: Leonard Ehrenfried <mail@leonard.io>

commit a132709
Author: McKenzie Maidl <40008048+mckenzie-maidl-ibigroup@users.noreply.github.com>
Date:   Tue Jul 26 13:58:04 2022 -0700

    addition of cause_detail and effect_detail to the spec (google#332)

commit 8993a24
Author: Zsombor Welker <flaktack@users.noreply.github.com>
Date:   Mon Jul 25 14:49:40 2022 +0200

    Add WheelchairAccessible documentation (google#340)
@drewda drewda mentioned this pull request Dec 1, 2022
Merged
isabelle-dr pushed a commit to MobilityData/transit that referenced this pull request Dec 19, 2023
@emmambd @omar-kabbani
review: adding issue templates (#64)
65ffbb0 
* Squashed commit of the following:

commit 2e6887e
Author: scmcca <scott@mobilitydata.org>
Date:   Wed Feb 2 12:42:10 2022 -0500

    [Formatting fix] Add newlines before lists

    Improved syntax for different markdown parsers

commit 0033573
Author: Tristram Gräbener <tristramg@gmail.com>
Date:   Fri Jan 28 15:54:00 2022 +0100

    Specify that the filename are case sensitive (google#300)

    Closes google#297

commit 23d877e
Author: scott christian mccallum <scott@mobilitydata.org>
Date:   Tue Jan 18 19:09:46 2022 -0500

    "Fields" and "Values" as non-header (google#302)

* Squashed commit of the following:

commit 9d5ebf1
Author: Guillaume Campagna <guillaume.campagna@gmail.com>
Date:   Tue Jul 26 17:09:35 2022 -0400

    Add trip-to-trip transfers with in-seat option (google#303)

    * Add trip-to-trip transfers with in-seat option

    * Fix stop_id are **Conditionally Required** and formatting

    * Add clarification about potential conflict

    * Fix typo

    Co-authored-by: Leonard Ehrenfried <mail@leonard.io>

    Co-authored-by: Nicholas Paun <np@icebergsystems.ca>
    Co-authored-by: Leonard Ehrenfried <mail@leonard.io>

commit a132709
Author: McKenzie Maidl <40008048+mckenzie-maidl-ibigroup@users.noreply.github.com>
Date:   Tue Jul 26 13:58:04 2022 -0700

    addition of cause_detail and effect_detail to the spec (google#332)

commit 8993a24
Author: Zsombor Welker <flaktack@users.noreply.github.com>
Date:   Mon Jul 25 14:49:40 2022 +0200

    Add WheelchairAccessible documentation (google#340)

* Update README.md (#63)

* issue templates

* update use cases section

* update contact links

* rename

* Delete .github/ISSUE_TEMPLATE/spec_improvement.yml

---------

Co-authored-by: scmcca <scott@mobilitydata.org>
Co-authored-by: omar-kabbani <78552622+omar-kabbani@users.noreply.github.com>
Co-authored-by: Emma Jae Blue <emma@Emma-Jae-Blue.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@flaktack @gcamp @leonardehrenfried @BodoMinea @skinkie @brodyFlannigan @hannesj @jfabi @scmcca