Refactor/reorg test driver to resurect browser testing. #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests run but the mocha progress bar over-writes itself until the feature tests also converted to ES6 (in progress). Add MochaDepencencies.js for platform probing Refactor TraceurTestRunner to glob asynchonously Refactor TraceurTestRunner -> BrowserTestRunner, NodeTestRunner Add node-only: to exclude node-specific tests. (Formerly just not included in testRunner.html). Tweek ModuleStore error message to add URL. Reorg unit test classes to run() in the endpoint so error messages are easier to place.
| server.on('error', function(e) { | ||
| console.log('Port ' + port + ' did not work out'); | ||
| console.log('Port ' + port + ' did not work out'); |
|
Very nice. Looking forward to run the test with a real debugger again. |
|
PTAL |
| var express = require('express'); | ||
| var http = require('http'); | ||
| var serveIndex = require('serve-index'); | ||
|
|
There was a problem hiding this comment.
Does this need a copyright header?
|
PTAL |
| unitTestRunner.run().then( | ||
| (failures) => { | ||
| process.exit(failures); |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on
demo/expressServer.jsto expand the test list into alist of files using the same functions called by the node test driver.
This dependency cost is balanced by no longer having to manually
ensure the tests are added to
testRunner.htmlStatus: Tests run but the mocha progress bar over-writes itself
until the feature tests also converted to ES6 (in progress).
Add MochaDepencencies.js for platform probing.
Refactor TraceurTestRunner to glob asynchronously.
Refactor TraceurTestRunner -> BrowserTestRunner, NodeTestRunner.
Add "node-only:" prefix to
suite()titles to exclude node-specific tests.(Formerly just not included in testRunner.html).
Tweek ModuleStore error message to add URL.
Reorg unit test classes to run() in the endpoint so error messages are
easier to place.