Skip to content

Commit

Permalink
tools/syz-check: add some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
dvyukov committed Dec 22, 2019
1 parent 9b81e6b commit 1461be9
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tools/syz-check/check.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,18 @@ func checkStruct(typ *prog.StructDesc, astStruct *ast.Struct, str *dwarf.StructT
}
// TODO: we could also check enums (elements match corresponding flags in syzkaller).
// TODO: we could also check values of literal constants (dwarf should have that, right?).
// TODO: handle nested structs/unions, e.g.:
// struct foo {
// union {
// ...
// } bar;
// };
// should be matched with:
// foo_bar [
// ...
// ]
// TODO: consider making guesses about semantic types of fields,
// e.g. if a name contains filedes/uid/pid/gid that may be the corresponding resource.
ai := 0
offset := uint64(0)
for _, field := range typ.Fields {
Expand Down

0 comments on commit 1461be9

Please sign in to comment.