Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Python interpreter can now be overridden #87

Merged
merged 4 commits into from
Dec 19, 2018

Conversation

apt-itude
Copy link
Contributor

@apt-itude apt-itude commented Nov 14, 2018

In case the Python runtime used to build a par is not exactly the same path as the target interpreter, this allows the interpreter to be explicitly set instead of inferred from the stub file.

Example:

par_binary(
    name = "mybinary",
    srcs = ["mybinary.py"],
    compiler_args = ["--interpreter", "/usr/bin/env python3.6"],
)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@apt-itude
Copy link
Contributor Author

I signed it!

(alex@128technology.com should now be a member of opensource@128technology.com)

Copy link
Contributor

@duggelz duggelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apt-itude Unfortunately I no longer work for Google, and don't have commit access to this repo any longer. Change looks good to me. A test case would be nice, though.

@tmc
Copy link

tmc commented Dec 15, 2018

@apt-itude this adds a basic test: tmc@4db9b96

@brandjon
Copy link
Contributor

tmc@ expressed an interest in forking this PR. Regarding the CLA situation: I believe the CLA bot hasn't updated this PR because no new commit has been pushed, but I can verify that alex@128technology.com is covered by the 128 Technology CLA.

@apt-itude
Copy link
Contributor Author

Hey guys, sorry I haven't been on top of this. I'll push a new commit with that test case.

@googlebot
Copy link

CLAs look good, thanks!

@brandjon brandjon merged commit a4f9b23 into google:master Dec 19, 2018
@brandjon
Copy link
Contributor

Thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants