Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable false positives reported by pylint #373

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions slo_generator/migrations/migrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ def exporters_v1tov2(
exp_keys = []
for exp_path in exporters_paths:
with open(exp_path, encoding="utf-8") as conf:
# pylint: disable=E1111
content = yaml.load(conf, Loader=yaml.SafeLoader)
exporters = content

Expand Down Expand Up @@ -284,7 +285,9 @@ def ebp_v1tov2(ebp_paths: list, shared_config: dict = {}, quiet: bool = False) -
ebp_keys = []
for ebp_path in ebp_paths:
with open(ebp_path, encoding="utf-8") as conf:
# pylint: disable=E1111
error_budget_policy = yaml.load(conf, Loader=yaml.SafeLoader)
# pylint: disable=E1133
for step in error_budget_policy:
step["name"] = step.pop("error_budget_policy_step_name")
step["burn_rate_threshold"] = step.pop("alerting_burn_rate_threshold")
Expand Down