feat: add support for OpenSearch backend #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maximepln, thanks a lot for this submission. I will take a look at it shortly. Regarding your choice of going with two different backends (with some duplicate code), I ended up doing the exact same thing to support MQL in Cloud Monitoring on top of the existing MQF backend. |
lvaylet
changed the title
lvaylet
requested changes
Sep 6, 2023
|
Thanks for the feedback @lvaylet, I updated to code to use Don't hesitate if you have any other comments |
lvaylet
requested changes
Sep 8, 2023
|
Hi @lvaylet, Sorry for the delay to respond, I was away on holiday. Hope everything is fine now |
|
hello @lvaylet, any updates ? |
|
I will take a look tomorrow afternoon. |
lvaylet
approved these changes
Oct 4, 2023
lvaylet
pushed a commit
that referenced
this pull request
Oct 20, 2023
* feat(Backend): Add Opensearch as a backend provider * fix: naming of package * fix: disable pylint code duplication * fix: rename opensearch to OpenSearch * fix: Opensearch to OpenSearch and opensearch to open_search * fix: few typo comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is in the title but I will add a bit of details
The goal of that PR is to implement a new backend provider
OpensearchFor instance, I opened an issue about this there: Issue 346,
in which I explained why the
Elasticsearchwasn't usable withOpensearchAs you will see, some code could have been mutualised between the two backend. But as we don't know the direction that will take the 2 backends in the future, and due to the fact that they could become quite different, I chose to avoid adding too much complexity.
Furthermore, most of the people will work on either
OpensearchorElasticsearchso having a common codebase could become complicated when wanting to add new features.Everything is documented in the right directories and unit tests & mocks were implemented.