This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
run-drc-for-cell-gds-using-magic: Add action.yml #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should really be checking that the action actually runs.... |
mithro
force-pushed
the
actions.yml
branch
2 times, most recently
from
c2c2820
to
3ed3654
Compare
By adding an `action.yml` the fact that the action is using docker is hidden and allows us to convert to a javascript action in the future if we want. It also makes handing over the inputs nicer and makes it easier to move between container registries if needed. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Add a command line argument to allow the check to look for the `./cells` in a directory other than the current working directory. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Fixes google#25. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro
force-pushed
the
actions.yml
branch
5 times, most recently
from
15c5b50
to
2376ab4
Compare
Make an ignored error clear by using a black tick and adding message. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro
force-pushed
the
actions.yml
branch
3 times, most recently
from
562172e
to
22fbfa5
Compare
Rename `match-directories` argument to `match-cells-directories` to better describe what it actually does. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
|
@donn - Would be great for you to look over this pull request and see the changes I ended up making. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding an
action.ymlthe fact that the action is using docker ishidden and allows us to convert to a javascript action in the future if
we want.
It also makes handing over the inputs nicer and makes it easier to move
between container registries if needed.
Signed-off-by: Tim 'mithro' Ansell tansell@google.com