Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Create check-drcs-for-cell-gds-using-magic #14

Merged
merged 1 commit into from
May 18, 2021
Merged

Create check-drcs-for-cell-gds-using-magic #14

merged 1 commit into from
May 18, 2021

Conversation

donn
Copy link
Contributor

@donn donn commented May 5, 2021

Externally usable GitHub action that runs magic's drc on all the gds files under cells/.

Tested with donn/skywater-pdk-libs-sky130_fd_sc_hd.

@google-cla

This comment has been minimized.

Sign in to view
@donn donn changed the title Creates modules-magic-drc Create modules-magic-drc May 5, 2021
@mithro

This comment has been minimized.

Sign in to view
@google-cla

This comment has been minimized.

Sign in to view
2 similar comments
@google-cla

This comment has been minimized.

Sign in to view
@google-cla

This comment has been minimized.

Sign in to view
@donn

This comment has been minimized.

Sign in to view
@donn
Copy link
Contributor Author

donn commented May 8, 2021

Hallelujah. @mithro, your cue.

@mithro mithro self-requested a review May 8, 2021 22:53
mithro
mithro reviewed May 8, 2021
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks pretty good.

Some minor comments which need fixing.

modules-magic-drc/Dockerfile Outdated Show resolved Hide resolved
modules-magic-drc/Dockerfile Outdated Show resolved Hide resolved
modules-magic-drc/run_standard_drc.py Outdated Show resolved Hide resolved
modules-magic-drc/run_standard_drc.py Outdated Show resolved Hide resolved
modules-magic-drc/run_standard_drc.py Outdated Show resolved Hide resolved
modules-magic-drc/pdk_subset/libs.tech/magic/sky130A.tcl Outdated Show resolved Hide resolved
modules-magic-drc/pdk_subset/libs.tech/magic/sky130A.tech Outdated Show resolved Hide resolved
modules-magic-drc/run_all_drc.py Outdated Show resolved Hide resolved
modules-magic-drc/run_all_drc.py Outdated Show resolved Hide resolved
modules-magic-drc/run_all_drc.py Outdated Show resolved Hide resolved
@donn
Copy link
Contributor Author

donn commented May 8, 2021

@mithro wrt run_standard_drc.py, the file is lifted from open_pdks so I'll save myself a headache and curl it. It will not be tracked in this repository.

Commenting on the rest individually…

@donn donn marked this pull request as draft May 12, 2021 02:28
@donn donn marked this pull request as ready for review May 12, 2021 04:21
@donn
Copy link
Contributor Author

donn commented May 12, 2021

@mithro Ready: recommend squash and merge because of the large number of changes between the three commits and to avoid tracking large files in the commit history.

umarcor
umarcor reviewed May 12, 2021
View reviewed changes
magic-gds-drc/action.yml Outdated Show resolved Hide resolved
magic-gds-drc/Dockerfile Outdated Show resolved Hide resolved
@donn donn changed the title Create modules-magic-drc Create magic-gds-drc May 12, 2021
@donn donn requested a review from mithro May 12, 2021 19:08
@mithro
Copy link
Contributor

mithro commented May 12, 2021

Screenshot from 2021-05-12 12-11-45

mithro
mithro suggested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting pretty close!

.github/workflows/prebuild-magic-gds-drc.yml Outdated Show resolved Hide resolved
.github/workflows/prebuild-magic-gds-drc.yml Outdated Show resolved Hide resolved
magic-gds-drc/Dockerfile Outdated Show resolved Hide resolved
magic-gds-drc/Dockerfile Outdated Show resolved Hide resolved
magic-gds-drc/Dockerfile Outdated Show resolved Hide resolved
magic-gds-drc/run_all_drc.py Outdated Show resolved Hide resolved
magic-gds-drc/run_all_drc.py Outdated Show resolved Hide resolved
magic-gds-drc/run_all_drc.py Outdated Show resolved Hide resolved
magic-gds-drc/run_all_drc.py Outdated Show resolved Hide resolved
magic-gds-drc/run_all_drc.py Outdated Show resolved Hide resolved
@donn donn requested a review from mithro May 17, 2021 08:35
@donn donn changed the title Create magic-gds-drc Create check-drcs-for-cell-gds-using-magic May 17, 2021
mithro
mithro reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @donn,

Rather than put another round of review comments on this pull request, I just fixed the changes directly.

The things that I did where;

  • Make the Python file pass flake8 test.
  • Actually generate the README.rst file from README.src.rst.
  • Renamed from check-drcs-for-cell-gds-using-magic to run-drc-for-cell-gds-using-magic. Previously it read "check design rule checkss for ...".
  • Cleaned up trailing whitespace and line continuations.
  • Delete temporary files in the same docker command they were used.
  • Probably some other smaller stuff.

Please take a look.

@donn
Copy link
Contributor Author

donn commented May 18, 2021

I'll ensure the test I have still works...

@donn
Copy link
Contributor Author

donn commented May 18, 2021

I've noticed that you've changed the copyright headers from efabless to "The Skywater PDK Authors" across the board. I'm not aware of any agreement to reassign copyright…

@mithro
Copy link
Contributor

mithro commented May 18, 2021

@donn Regarding the copyright headers -- see https://opensource.google/docs/releasing/authors/

@donn
Copy link
Contributor Author

donn commented May 18, 2021

I've updated the authors file to reflect Efabless's legal name, but other than that, signing off on this.

@donn @mithro
Creating a GitHub Action to run DRC checks on cells.
f96e868 
This GitHub Action uses Magic to run the SKY130 design rules pulled from
OpenPDKs on all the cells in a standard library.

See the `README.rst` for instructions on how to use.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Mohamed Gaber <mohamed.gaber@efabless.com>
@mithro mithro merged commit 25e3792 into google:main May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@umarcor umarcor umarcor left review comments

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donn @mithro @umarcor