Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom events for analytics tracking box. #1168

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Add custom events for analytics tracking box. #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d679b6e
Add custom events for analytics tracking box.
Shavindra Feb 24, 2020
ab1e729
Merge branch 'develop' into fix/1049-analytics-tracking-custom-events
aaemnnosttv Mar 4, 2020
5179bd0
Fix typo in event category.
aaemnnosttv Mar 4, 2020
db1f666
Update formatting.
aaemnnosttv Mar 4, 2020
17e849b
Merge branch 'develop' into fix/1049-analytics-tracking-custom-events
felixarntz Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/components/activation/activation-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function ActivationMain( { buttonURL, onButtonClick, buttonLabel } ) {
<Fragment>
{ CTAFeedback }

<OptIn />
<OptIn optinAction="analytics_optin_setup_banner" />

<div className="googlesitekit-start-setup-wrap">
<Button
Expand Down
6 changes: 6 additions & 0 deletions assets/js/components/optin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import { __ } from '@wordpress/i18n';
import {
isTrackingEnabled,
toggleTracking,
trackEvent,
} from '../util/tracking';

class OptIn extends Component {
Expand All @@ -56,6 +57,10 @@ class OptIn extends Component {

toggleTracking( checked );

if ( checked ) {
trackEvent( 'tracking_plugin', this.props.optinAction );
}

apiFetch( {
path: '/wp/v2/users/me',
method: 'POST',
Expand Down Expand Up @@ -123,6 +128,7 @@ OptIn.propTypes = {
id: PropTypes.string,
name: PropTypes.string,
className: PropTypes.string,
optinAction: PropTypes.string,
};

OptIn.defaultProps = {
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/settings/settings-admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class SettingsAdmin extends Component {
googlesitekit-settings-module__meta-item
googlesitekit-settings-module__meta-item--nomargin
">
<OptIn />
<OptIn optinAction="analytics_optin_settings_page" />
</div>
</div>
</div>
Expand Down
3 changes: 2 additions & 1 deletion assets/js/components/setup-wizard/wizard-step-authentication.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ class WizardStepAuthentication extends Component {
}
</p>
<div className="googlesitekit-wizard-step__action googlesitekit-wizard-step__action--justify">
<OptIn />
<OptIn optinAction="analytics_optin_setup_fallback" />

<HelpLink />
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/setup/setup-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class SetupUsingProxy extends Component {
<Fragment>
{ CTAFeedback }

<OptIn />
<OptIn optinAction="analytics_optin_setup_fallback" />

<div className="googlesitekit-start-setup-wrap">
<Button
Expand Down