Hash-pin Python dependencies in CI/CD release workflows #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #934. That PR hash-pinned the GitHub Actions used in sentencepiece's workflows, and this PR hash-pins the Python dependencies used in
cmake.ymlandwheels.yml.Both of these workflows create Python artifacts that are published as release artifacts. Python dependencies can also be used as vectors for supply-chain attacks that modify these release artifacts. By hash-pinning the dependencies, we ensure we always get exactly the same dependencies.
This PR also configures Dependabot to monitor these Python dependencies, sending a single monthly PR updating all packages with new versions. See the PR it sent to my fork for an example: pnacht#2.