-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply PEP621 #388
apply PEP621 #388
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
60d97e7
to
33c5eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give a bit more info than just "apply PEP 621"? I don't know anything about Python packaging, so a few sentences of explanation would be helpful.
https://google.github.io/eng-practices/review/developer/cl-descriptions.html#informative
@selimnairb This is moving the |
@jmr Yes, I'll pull it down today and have a look. |
Co-authored-by: Zach Burnett <zachary.r.burnett@gmail.com>
Thanks! |
PEP621 (https://peps.python.org/pep-0621/) defines using the
pyproject.toml
file to store project metadata in the[project]
table. This has several advantages over usingsetup.cfg
orsetup.py
to store the project metadata, namely:pyproject.toml
is required by PEP517 (https://peps.python.org/pep-0517/) and many third party tools use it to store their configurationsetuptools
(such ashatch
ormeson
) to read the same project metadata