Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken test behaviors on old and new ICUs #75

Merged
merged 1 commit into from
May 8, 2020
Merged

Fixes broken test behaviors on old and new ICUs #75

merged 1 commit into from
May 8, 2020

Conversation

filmil
Copy link
Member

@filmil filmil commented May 8, 2020 •
edited
Loading

With the following changes, we should be well positioned to tackle
ICU 67.1

  • ICU4C correctly implements language fallbacks starting version 67.1,
    added two flavors of the same test, one for ICU versions 67 and
    onwards, and another for older versions. Feature:
    icu_version_67_plus. This happens in issue ICU 67.1 brings in new C fallback method in the API #59.
  • ICU4C version 63 has wrong result for a certain test, possibly due to
    the CLDR version on my machine, so test failed. Turned that test off
    for versions less than 64. This happens on my machine only, when the
    system ICU is used.

See also issue #76 for where this is going to start being used.

@filmil
Fixes broken test behaviors on old and new ICUs
4b8cf84 
With the following changes, we should be well positioned to tackle
ICU 67.1

- ICU4C correctly implements language fallbacks starting version 67.1,
  added two flavors of the same test, one for ICU versions 67 and
  onwards, and another for older versions.  Feature:
  `icu_version_67_plus`.  This happens in issue google#59.
- ICU4C version 63 has wrong result for a certain test, possibly due to
  the CLDR version on my machine, so test failed.  Turned that test off
  for versions less than 64.  This happens on my machine only, when the
  system ICU is used.
@filmil filmil mentioned this pull request May 8, 2020
Closed
filmil added a commit to filmil/rust_icu that referenced this pull request May 8, 2020
@filmil
Starts testing with ICU 67.1
302d620 
This is the last step in getting rust_icu tested with ICU 67.1  There
are a few pull requests in flight that preempt this one, such as google#75,
but once those are commited, this can go in. (And should pass.)

Fixes google#76.
@filmil filmil mentioned this pull request May 8, 2020
Merged
@filmil filmil requested a review from kpozin May 8, 2020 08:18
kpozin
kpozin approved these changes May 8, 2020
View reviewed changes
rust_icu_uloc/build.rs Show resolved Hide resolved
@filmil filmil merged commit de07929 into google:master May 8, 2020
filmil added a commit to filmil/rust_icu that referenced this pull request May 8, 2020
@filmil
Starts testing with ICU 67.1
fd13ef2 
This is the last step in getting rust_icu tested with ICU 67.1  There
are a few pull requests in flight that preempt this one, such as google#75,
but once those are commited, this can go in. (And should pass.)

Fixes google#76.
filmil added a commit to filmil/rust_icu that referenced this pull request May 8, 2020
@filmil
Starts testing with ICU 67.1
6e7ef8e 
This is the last step in getting rust_icu tested with ICU 67.1  There
are a few pull requests in flight that preempt this one, such as google#75,
but once those are commited, this can go in. (And should pass.)

Fixes google#76.
filmil added a commit to filmil/rust_icu that referenced this pull request May 8, 2020
@filmil
Starts testing with ICU 67.1
2957980 
This is the last step in getting rust_icu tested with ICU 67.1  There
are a few pull requests in flight that preempt this one, such as google#75,
but once those are commited, this can go in. (And should pass.)

Fixes google#76, google#83
filmil added a commit that referenced this pull request May 8, 2020
@filmil
Starts testing with ICU 67.1
0850dd1 
This is the last step in getting rust_icu tested with ICU 67.1  There
are a few pull requests in flight that preempt this one, such as #75,
but once those are commited, this can go in. (And should pass.)

Fixes #76, #83
@filmil filmil deleted the icu-67 branch September 17, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpozin kpozin kpozin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filmil @kpozin