Use checked maths #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adetaylor
commented
Nov 10, 2023
| @@ -564,23 +564,33 @@ pub(crate) struct SeekableHttpReader { | |||
|
|
|||
| impl Seek for SeekableHttpReader { | |||
| fn seek(&mut self, pos: std::io::SeekFrom) -> std::io::Result<u64> { | |||
| // TODO used checked arithmetic when stabilized | |||
There was a problem hiding this comment.
This TODO actually was in reference to a proposal to allow checked arithmetic between disparate types, e.g. u64 and i64. However using try_into is just as good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO which was insufficiently detailed, and adds a MSRV.
Fixes #48.