-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pybind11 IWYU pragmas (for clangd Include Cleaner) #30152
Draft
rwgk
wants to merge
39
commits into
google:main
Choose a base branch
from
rwgk:iwyu_pragmas_pybind11clif
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging and upstreaming this PR is deferred until Include Cleaner supports removing the "third_party/pybind11/include/" path name parts.
…cord_pyobject.h, google#30099).
…art_holder_from_shared_ptr()`, to achieve successful building. (Testing aborts with a segfault in test_class_release_gil_before_calling_cpp_dtor.py)
…m smart_holder_type_casters.h to type_caster_base.h Resolve all `PYBIND11K_MERGE_SH_AFTER_PR5257_WIP` in test_return_value_policy_override.py (in other words, restore the original complete tests).
…_casters.h to type_caster_base.h Restore the original, complete test_class_sh_void_ptr_capsule.py
…nd11k_merge_sh_after_pr5257
…nd11k_merge_sh_after_pr5257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Originally under #30073][Then moved to #30113] Then moved here.
This PR is the source of truth for google3_iwyu_pragmas.patch
Merging and upstreaming this PR is deferred until the clangd Include Cleaner supports removing the "third_party/pybind11/include/" path name parts.
For easy future reference: commit 9e5f44d here was submitted as cl/577013593.
Suggested changelog entry: