git merge smart_holder #30151

PREPARATION for: PR google#5332 — Fix handling of const unique_ptr<T, D> & (do not disown). Splitting out so that the functional changes under PR google#5332 will be more obvious.

…#5334) PREPARATION for: PR google#5332 — Fix handling of const unique_ptr<T, D> & (do not disown). Splitting out so that the functional changes under PR google#5332 will be more obvious. The only functional change under this PR is that ``` assert(custom_deleter_ptr != nullptr); ``` is replaced with: ``` if (custom_deleter_ptr == nullptr) { throw std::runtime_error( std::string("smart_holder::extract_deleter() precondition failure (") + context + ")."); } ```

@iwanders

…own). (google#5332) * Replace `unique_ptr_cref_roundtrip()` with `pass_unique_ptr_cref()`, `rtrn_unique_ptr_cref()` to make the current behavior obvious. * add in unique_ptr_storage, unique_ptr_storage_deleter * Add shared_ptr_storage (with that disowning fails as expected). * Add load_as_const_unique_ptr() * Restore original struct_smart_holder.h * factor out `smart_holder::extract_deleter()` * Better error message. * Misc cleanup/tidying. * Use `re.match("ctor_arg(_MvCtor)*_MvCtor", ...)` for compatibility with MSVC, NVHPC, ICC * Add small comments. * Fix small, inconsequential oversight in test code. * Apply suggestion by @iwanders under PR google#5334 * Remove `std::move()` in `smart_holder::extract_deleter()` * Add `static_assert()` following a suggestion by @iwanders under PR google#5334

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

git merge smart_holder #30151

git merge smart_holder #30151

Commits on Aug 25, 2024