Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Systematically change pywrapcc to pybind11k #30126

Merged
merged 1 commit into from
Jun 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/classes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -557,4 +557,4 @@ The ``name`` property returns the name of the enum value as a unicode string.
.. note::

``py::native_enum`` was added as an alternative to ``py::enum_``
with http://github.com/google/pywrapcc/pull/30005
with http://github.com/google/pybind11k/pull/30005
2 changes: 1 addition & 1 deletion include/pybind11/detail/class.h
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ inline bool ensure_base_init_functions_were_called(PyObject *self) {
return true;
}

// See google/pywrapcc#30095 for background.
// See google/pybind11k#30095 for background.
#if !defined(PYBIND11_INIT_SAFETY_CHECKS_VIA_INTERCEPTING_TP_INIT) \
&& !defined(PYBIND11_INIT_SAFETY_CHECKS_VIA_DEFAULT_PYBIND11_METACLASS)
# if !defined(PYPY_VERSION)
Expand Down
2 changes: 1 addition & 1 deletion include/pybind11/detail/function_record_pyobject.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// For background see the description of PR google/pywrapcc#30099.
// For background see the description of PR google/pybind11k#30099.

#pragma once

Expand Down
2 changes: 1 addition & 1 deletion include/pybind11/detail/internals.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ struct internals {
# if PYBIND11_INTERNALS_VERSION > 4
// Note that we have to use a std::string to allocate memory to ensure a unique address
// We want unique addresses since we use pointer equality to compare function records
// OBSOLETE: google/pywrapcc#30099
// OBSOLETE: google/pybind11k#30099
std::string function_record_capsule_name = internals_function_record_capsule_name;
# endif

Expand Down
2 changes: 1 addition & 1 deletion include/pybind11/pybind11.h
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ class cpp_function : public function {
if (rec->name == nullptr) {
rec->name = guarded_strdup("");
} else if (std::strcmp(rec->name, "__setstate__[non-constructor]") == 0) {
// See google/pywrapcc#30094 for background.
// See google/pybind11k#30094 for background.
rec->name = guarded_strdup("__setstate__");
} else {
rec->name = guarded_strdup(rec->name);
Expand Down
4 changes: 2 additions & 2 deletions include/pybind11/stl.h
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ struct array_caster {
bool convert_elements(handle seq, bool convert) {
auto l = reinterpret_borrow<sequence>(seq);
value.reset(new ArrayType{});
// Using `resize` to preserve the behavior exactly as it was before google/pywrapcc#30034
// Using `resize` to preserve the behavior exactly as it was before google/pybind11k#30034
// For the `resize` to work, `Value` must be default constructible.
// For `std::valarray`, this is a requirement:
// https://en.cppreference.com/w/cpp/named_req/NumericType
Expand Down Expand Up @@ -453,7 +453,7 @@ struct array_caster {
}

// Code copied from PYBIND11_TYPE_CASTER macro.
// Intentionally preserving the behavior exactly as it was before google/pywrapcc#30034
// Intentionally preserving the behavior exactly as it was before google/pybind11k#30034
template <typename T_, enable_if_t<std::is_same<ArrayType, remove_cv_t<T_>>::value, int> = 0>
static handle cast(T_ *src, const return_value_policy_pack &policy, handle parent) {
if (!src) {
Expand Down
4 changes: 2 additions & 2 deletions tests/test_pickling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void wrap(py::module m) {

namespace exercise_getinitargs_getstate_setstate {

// Exercise `__setstate__[non-constructor]` (see google/pywrapcc#30094), which
// Exercise `__setstate__[non-constructor]` (see google/pybind11k#30094), which
// was added to support a pickle protocol as established with Boost.Python
// (in 2002):
// https://www.boost.org/doc/libs/1_31_0/libs/python/doc/v2/pickle.html
Expand Down Expand Up @@ -103,7 +103,7 @@ void wrap(py::module m) {
},
py::arg("protocol") = -1)
.def(
"__setstate__[non-constructor]", // See google/pywrapcc#30094 for background.
"__setstate__[non-constructor]", // See google/pybind11k#30094 for background.
[](StoreTwoWithState *self, const std::string &state) { self->SetState(state); },
py::arg("state"));
}
Expand Down
Loading