Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::addressof() in type_caster_base.h and smart_holder_type_casters.h #30093

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Use std::addressof() in type_caster_base.h and smart_holder_type_casters.h #30093

merged 7 commits into from
Jan 24, 2024

Commits on Jan 22, 2024

  1. changes as transferred from CL

    Ralf W. Grosse-Kunstleve committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a894a66 View commit details
    Browse the repository at this point in the history

  2. Add minimal tests.

    Ralf W. Grosse-Kunstleve committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    36d145c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Add non_trivial_member to make the test more realistic and avoid cl… 

    …ang-tidy errors.
    Ralf W. Grosse-Kunstleve committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    993ae23 View commit details
    Browse the repository at this point in the history

  2. Also cover CastConstRef (to be verified).

    Ralf W. Grosse-Kunstleve committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    82c3482 View commit details
    Browse the repository at this point in the history

  3. type_caster::cast(const &) evidently does not need std::addressof()

    Ralf W. Grosse-Kunstleve committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bcc40b2 View commit details
    Browse the repository at this point in the history

  4. Slightly simplify UnusualOpRef

    Ralf W. Grosse-Kunstleve committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4254193 View commit details
    Browse the repository at this point in the history

  5. Reorganize tests so that it is easy to backport the type_caster_base.… 

    …h change plus test.
    Ralf W. Grosse-Kunstleve committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0c53713 View commit details
    Browse the repository at this point in the history