Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git merge smart_holder #30078

Merged
merged 8 commits into from
Nov 8, 2023
Merged

git merge smart_holder #30078

merged 8 commits into from
Nov 8, 2023

Commits on Nov 4, 2023

  1. fix doc typo

    Social-Mean authored and henryiii committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    31b0a5d View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Use newer PyCode API and other fixes (google#4916)

    * Use PyCode API
    
    * style: pre-commit fixes
    
    * Free locals
    
    * Fix PY_VERSION_HEX check
    
    ---------
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    cyyever and pre-commit-ci[bot] authored Nov 5, 2023
    Configuration menu
    Copy the full SHA
    f260693 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. fix(smart_holder): Use std::default_delete. (google#4924)

    Ensures `std::default_delete<T>` is used to look up the deleter for a type instead of `delete` directly.
    iwanders authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e02fe00 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. [smart_holder] Unique ptr deleter roundtrip tests and fix (google#4921)

    * Roundtrip through unique pointer with custom deleter.
    
    Currently failing.
    
    * Ensure the custom deleter is copied back to the unique pointer.
    
    Feels like there's still a gap around the raw pointer flavour, but this at least
    makes the unit test of the previous commit succeed.
    
    * Add deleter roundtrip for const atyp.
    
    Currently failing, custom deleter is lost.
    
    * Fix storing deleter for const unique ptr.
    
    Unit test from the previous commit passes.
    
    * Remove SFINEA deleter assignment.
    
    At the construction of the smart holder, it is either a del_fun, or a default constructed deleter, so this complexity is unnecessary.
    
    * Clang format.
    
    * Fixes for ci.
    
    Clang 3.6 requires the extra constructors in the custom_deleter.
    
    * fix(smart_holder): Loosen requirement on deleter to be default constructible.
    
    And some other PR feedback.
    
    * fix(smart_holder): Custom deleter in unit tests traces constructions.
    
    * fix(smart_holder): Use pybind11_fail instead of assert.
    
    * fix(smart_holder): Add unit tests for the default constructible deleter.
    
    * fix(smart_holder): Use regex matching for deleter constructors in unit tests.
    iwanders authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e5ce963 View commit details
    Browse the repository at this point in the history
  2. chore(deps): update pre-commit hooks (google#4923)

    updates:
    - [github.com/pre-commit/mirrors-clang-format: v17.0.3 → v17.0.4](pre-commit/mirrors-clang-format@v17.0.3...v17.0.4)
    - [github.com/astral-sh/ruff-pre-commit: v0.1.2 → v0.1.4](astral-sh/ruff-pre-commit@v0.1.2...v0.1.4)
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    pre-commit-ci[bot] authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    0a974fe View commit details
    Browse the repository at this point in the history
  3. chore: move to ruff-format (google#4912)

    Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
    Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
    henryiii and Ralf W. Grosse-Kunstleve authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c758b81 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into sh_merge_master

    Ralf W. Grosse-Kunstleve committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    124b62a View commit details
    Browse the repository at this point in the history
  5. Merge branch 'sh_merge_master' into pywrapcc_merge_sh

    Ralf W. Grosse-Kunstleve committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a3a9087 View commit details
    Browse the repository at this point in the history