Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git merge smart_holder (https://github.com/pybind/pybind11/pull/4907) #30074

Merged
merged 7 commits into from
Oct 27, 2023

Conversation

rwgk
Copy link
Contributor

@rwgk rwgk commented Oct 27, 2023

Description

Helper/scratch PR for testing.

Suggested changelog entry:

ellert and others added 5 commits October 24, 2023 09:46
According to https://docs.python.org/3.13/whatsnew/3.13.html:

Add PyThreadState_GetUnchecked() function: similar to
PyThreadState_Get(), but don't kill the process with a fatal error if
it is NULL. The caller is responsible to check if the result is
NULL. Previously, the function was private and known as
_PyThreadState_UncheckedGet().
* [minor] Add a missing space

Add a missing space to error message

* Add space after period, always add newline.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@google-cla
Copy link

google-cla bot commented Oct 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Ralf W. Grosse-Kunstleve added 2 commits October 26, 2023 22:48
```
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

ubench/holder_comparison.py:12: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
```
@rwgk rwgk changed the title git merge smart_holder git merge smart_holder (https://github.com/pybind/pybind11/pull/4907) Oct 27, 2023
@rwgk
Copy link
Contributor Author

rwgk commented Oct 27, 2023

Ignoring a test_iostream flake.

@rwgk rwgk marked this pull request as ready for review October 27, 2023 06:57
@rwgk rwgk merged commit d6c9375 into google:main Oct 27, 2023
146 of 147 checks passed
@rwgk rwgk deleted the pywrapcc_merge_sh branch October 27, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants