git merge smart_holder #30039
Merged
git merge smart_holder #30039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PyUnicode_DecodeLatin1` requires you to pass in the `error` parameter. The code as it is in the docs didn't compile. There is a reference leak in the example code. `PyUnicode_DecodeLatin1` returns a new reference. Calling `py::str(PyObject*)` calls `PyObject_Str`, which also returns a new reference. That reference is managed by the `py::str` constructor (which correctly steals the reference, using the `stolen_t` constructor), but the original reference returned by `PyUnicode_DecodeLatin1` is never decref'd: it never makes it into an `object`, and it's never manually decremented. This fixes both of those issues. The code compiles, and I viewed the sphinx docs locally.
* set ci.yml minimal permissions Signed-off-by: Joyce <joycebrum@google.com> * set configure.yml minimal permissions Signed-off-by: Joyce <joycebrum@google.com> * set format.yml minimal permissions Signed-off-by: Joyce <joycebrum@google.com> * set pip.yml minimal permissions Signed-off-by: Joyce <joycebrum@google.com> * set upstream.yml minimal permissions Signed-off-by: Joyce <joycebrum@google.com> * set labeler.yml minimal permissions Signed-off-by: Joyce <joycebrum@google.com> * Update ci.yml to read all Signed-off-by: Joyce <joycebrum@google.com> * test labeler.yml Signed-off-by: Joyce <joycebrum@google.com> * restore the if at labeler.yml Signed-off-by: Joyce <joycebrum@google.com> --------- Signed-off-by: Joyce <joycebrum@google.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This suggestion was also applied here: pybind/pybind11#4665 (comment) Settings -> Actions permissions -> Workflow permissions: Checked "Read repository contents and packages permissions" |
|
Ignoring 1 frequent flake (test_iostream): CI / 🐍 3.7 • MSVC 2019 • x86 -DCMAKE_CXX_STANDARD=14 (pull_request) Failing after 9m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helper/scratch PR for testing.
Suggested changelog entry: