Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fixed32 to be parsed as unsigned when parsing proto3 protos #655

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix Fixed32 to be parsed as unsigned when parsing proto3 protos #655

merged 1 commit into from
May 17, 2022

Conversation

osa1
Copy link
Member

@osa1 osa1 commented May 17, 2022

Port of cl/389579992

@osa1 osa1 requested a review from sigurdm May 17, 2022 08:56
sigurdm
sigurdm approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osa1 osa1 merged commit a68bb5a into google:master May 17, 2022
@osa1 osa1 deleted the proto3_json_fixed32 branch May 17, 2022 13:23
osa1 added a commit to osa1/protobuf.dart that referenced this pull request May 17, 2022
@osa1
Add google#655
72e4c55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osa1 @sigurdm