Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frozen message modification handling #643

Merged
merged 6 commits into from
Jun 15, 2022

Conversation

osa1
Copy link
Member

@osa1 osa1 commented May 9, 2022

See #175 for the problems with this API.

Internally this API is not used. However this is still a breaking change
and will be released with the next major release.

Fixes #175


Synced to internal in cl/450254014.

@osa1 osa1 requested a review from sigurdm May 9, 2022 14:07
See google#175 for the problems with this API.

Internally this API is not used. However this is still a breaking change
and will be released with the next major release.

Fixes google#175
@osa1 osa1 force-pushed the remove_frozen_msg_error_handler branch from ebba992 to a321d8f Compare May 9, 2022 14:10
@osa1 osa1 mentioned this pull request May 10, 2022
Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osa1 osa1 merged commit 598deb9 into google:master Jun 15, 2022
@osa1 osa1 deleted the remove_frozen_msg_error_handler branch June 15, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove frozenMessageModificationHandler
2 participants