Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Switch to use GitHub Actions instead of Travis, update analysis options #67

Merged
merged 1 commit into from
Aug 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/workflows/process.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Process Package

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
workflow_dispatch:

jobs:
correctness:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
- uses: dart-lang/setup-dart@9a04e6d73cca37bd455e0608d7e5092f881fd603
with:
sdk: dev
- name: Install dependencies
run: dart pub upgrade
- name: Verify formatting
run: dart format --output=none --set-exit-if-changed .
- name: Analyze project source
run: dart analyze --fatal-infos
test:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
sdk: [stable, beta, dev]
steps:
- uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
- uses: dart-lang/setup-dart@9a04e6d73cca37bd455e0608d7e5092f881fd603
with:
sdk: ${{ matrix.sdk }}
- name: Install dependencies
run: dart pub upgrade
- name: Run Tests
run: dart test
15 changes: 0 additions & 15 deletions .travis.yml

This file was deleted.

65 changes: 2 additions & 63 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,67 +1,6 @@
include: package:lints/recommended.yaml

analyzer:
enable-experiment:
- non-nullable
strong-mode:
implicit-dynamic: false
implicit-casts: false
errors:
missing_required_param: warning
missing_return: warning
# Allow having TODOs in the code
todo: ignore

linter:
rules:
# these rules are documented on and in the same order as
# the Dart Lint rules page to make maintenance easier
# http://dart-lang.github.io/linter/lints/

# === error rules ===
- avoid_empty_else
- comment_references
- cancel_subscriptions
- close_sinks
- control_flow_in_finally
- empty_statements
- hash_and_equals
- invariant_booleans
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- literal_only_boolean_expressions
- test_types_in_equals
- throw_in_finally
- unrelated_type_equality_checks
- valid_regexps

# === style rules ===
- always_declare_return_types
- always_specify_types
- annotate_overrides
- avoid_init_to_null
- avoid_return_types_on_setters
- await_only_futures
- camel_case_types
- constant_identifier_names
- empty_constructor_bodies
- implementation_imports
- library_names
- library_prefixes
- non_constant_identifier_names
- one_member_abstracts
- only_throw_errors
- overridden_fields
- package_api_docs
- package_prefixed_library_names
- prefer_is_not_empty
- public_member_api_docs
- slash_for_doc_comments
- sort_constructors_first
- sort_unnamed_constructors_first
- type_annotate_public_apis
- type_init_formals
- unawaited_futures
- unnecessary_brace_in_string_interps
- unnecessary_getters_setters

# === pub rules ===
- package_names
6 changes: 0 additions & 6 deletions dev/setup.sh

This file was deleted.

30 changes: 0 additions & 30 deletions dev/travis.sh

This file was deleted.

1 change: 1 addition & 0 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ dependencies:
platform: '^3.0.0'

dev_dependencies:
lints: ^1.0.1
test: ^1.16.8
25 changes: 13 additions & 12 deletions test/src/interface/common_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ void main() {
}

tearDown(() {
<Directory>[workingDir, dir1, dir2, dir3]
.forEach((Directory d) => d.deleteSync(recursive: true));
for (var directory in <Directory>[workingDir, dir1, dir2, dir3]) {
directory.deleteSync(recursive: true);
}
});

group('on windows', () {
Expand Down Expand Up @@ -227,24 +228,24 @@ void main() {

test('when path has spaces', () {
expect(
sanitizeExecutablePath('Program Files\\bla.exe',
sanitizeExecutablePath(r'Program Files\bla.exe',
platform: platform),
'"Program Files\\bla.exe"');
r'"Program Files\bla.exe"');
expect(
sanitizeExecutablePath('ProgramFiles\\bla.exe', platform: platform),
'ProgramFiles\\bla.exe');
sanitizeExecutablePath(r'ProgramFiles\bla.exe', platform: platform),
r'ProgramFiles\bla.exe');
expect(
sanitizeExecutablePath('"Program Files\\bla.exe"',
sanitizeExecutablePath(r'"Program Files\bla.exe"',
platform: platform),
'"Program Files\\bla.exe"');
r'"Program Files\bla.exe"');
expect(
sanitizeExecutablePath('\"Program Files\\bla.exe\"',
sanitizeExecutablePath(r'"Program Files\bla.exe"',
platform: platform),
'\"Program Files\\bla.exe\"');
r'"Program Files\bla.exe"');
expect(
sanitizeExecutablePath('C:\\\"Program Files\"\\bla.exe',
sanitizeExecutablePath(r'C:\"Program Files"\bla.exe',
platform: platform),
'C:\\\"Program Files\"\\bla.exe');
r'C:\"Program Files"\bla.exe');
});

test('with absolute path when currentDirectory getter throws', () {
Expand Down