Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Fix ProcessManager.canRun to be consistent with LocalProcessManager #62

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Fix ProcessManager.canRun to be consistent with LocalProcessManager #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd8de7f
Fix ProcessManager.canRun to be consistent with LocalProcessManager
jmagman Mar 23, 2021
236a0e1
signature
jmagman Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
#### 4.2.0

* Fix the signature of `ProcessManager.canRun` to be consistent with
`LocalProcessManager`.

#### 4.1.1

* Fixed `getExecutablePath()` to only return path items that are
Expand Down
2 changes: 1 addition & 1 deletion lib/src/interface/process_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ abstract class ProcessManager {
});

/// Returns `true` if the [executable] exists and if it can be executed.
bool canRun(dynamic executable, {String workingDirectory});
bool canRun(dynamic executable, {String? workingDirectory});

/// Kills the process with id [pid].
///
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: process
version: 4.1.1
version: 4.2.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a minor or patch bump?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏻‍♂️ this is fine

description: A pluggable, mockable process invocation abstraction for Dart.
homepage: https://github.com/google/process.dart

Expand Down