This repository has been archived by the owner on Dec 9, 2023. It is now read-only.
[null-safety] remove implicit casts, intl dependency, format #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
force-pushed
the
update_pre_null_safety
branch
from
0b4b334
to
a60a07e
Compare
jonahwilliams
changed the title
natebosch
reviewed
Jul 29, 2020
| Manifest manifest = new Manifest(); | ||
| (JsonDecoder().convert(json) as List<dynamic>) | ||
| .cast<Map<String, dynamic>>(); | ||
| Manifest manifest = Manifest(); |
There was a problem hiding this comment.
[optional] If you're doing cleanup anyway, consider removing some of the very clearly redundant local variable types.
There was a problem hiding this comment.
always_specify_types 🙃
| @@ -32,6 +32,48 @@ Encoding _getEncoding(String encoding) { | |||
|
|
|||
| /// An entry in the process invocation manifest for running an executable. | |||
| class RunManifestEntry extends ManifestEntry { | |||
| /// Creates a new manifest entry with the given properties. | |||
There was a problem hiding this comment.
This comment is not adding any information. How about removing it?
tvolkert
approved these changes
Jul 29, 2020
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
|
Can you bump the version and update the CHANGELOG as well? |
|
@tvolkert I have another commit ready that ops into null safety. I'll update the changelog but I don't really want to release two back to back |
|
got it - you want me to merge? |
|
Changelog/pubspec updated - ready when you are |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for null-safety which does not have implicit casts. Removes intl dependency which was only used for a single naming scheme.
Does not bump versioning or changelog