-
Notifications
You must be signed in to change notification settings - Fork 26
[null-safety] remove implicit casts, intl dependency, format #46
Conversation
0b4b334
to
a60a07e
Compare
Manifest manifest = new Manifest(); | ||
(JsonDecoder().convert(json) as List<dynamic>) | ||
.cast<Map<String, dynamic>>(); | ||
Manifest manifest = Manifest(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional] If you're doing cleanup anyway, consider removing some of the very clearly redundant local variable types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always_specify_types 🙃
@@ -32,6 +32,48 @@ Encoding _getEncoding(String encoding) { | |||
|
|||
/// An entry in the process invocation manifest for running an executable. | |||
class RunManifestEntry extends ManifestEntry { | |||
/// Creates a new manifest entry with the given properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is not adding any information. How about removing it?
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Can you bump the version and update the CHANGELOG as well? |
@tvolkert I have another commit ready that ops into null safety. I'll update the changelog but I don't really want to release two back to back |
got it - you want me to merge? |
Changelog/pubspec updated - ready when you are |
Preparation for null-safety which does not have implicit casts. Removes intl dependency which was only used for a single naming scheme.
Does not bump versioning or changelog