This repository has been archived by the owner on Dec 9, 2023. It is now read-only.
Don't add quotes if the file name already has quotes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Aug 9, 2019
| @@ -26,7 +26,7 @@ String sanitizeExecutablePath(String executable, | |||
| if (!platform.isWindows) { | |||
| return executable; | |||
| } | |||
| if (executable.contains(' ') && !executable.startsWith('"')) { | |||
| if (executable.contains(' ') && !executable.contains('"')) { | |||
There was a problem hiding this comment.
What if it contains \ (an escaped space)?
There was a problem hiding this comment.
I could be wrong, but my understanding is that: C:\"foo"\bar resolves as C:\foo\bar. If this is true, then C:\"foo^ bar" resolves as C:\foo^ bar. (^ is Windows way to escape spaces). I don't have a Windows computer, but let me ask to see if we can verify it.
There was a problem hiding this comment.
These paths are resolved correctly:
Process.runSync('"C:\\Users\\franciscojma\\Hello World\\git.exe"', const <String>[]);
Process.runSync('\"C:\\Users\\franciscojma\\Hello World\\git.exe\"', const <String>[]);The ones below returned "Process not found":
Process.runSync('C:\\Users\\franciscojma\\"Hello World"\\git.exe', const <String>[]);
Process.runSync('C:\\Users\\franciscojma\\"Hello^ World"\\git.exe', const <String>[]);
Process.runSync('"C:\\Users\\franciscojma\\Hello^ World"\\git.exe"', const <String>[]);
Process.runSync('C:\\Users\\franciscojma\\Hello^ World\\git.exe', const <String>[]);
tvolkert
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tvolkert