Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Fix: "ProcessException: %1 is not a valid Win32 application. #38

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

blasten
Copy link

@blasten blasten commented Aug 6, 2019

Description

Moved from flutter/flutter#37599

Add quoted strings to indicate where the file name ends and the arguments begin otherwise, the file name is ambiguous. dart-lang/sdk#37751

Related Issues

flutter/flutter#19359
flutter/flutter#33972
flutter/flutter#36607
flutter/flutter#36171
flutter/flutter#36152
flutter/flutter#35695
flutter/flutter#33023
flutter/flutter#31550
flutter/flutter#19304
flutter/flutter#15014

Tests

Unit tests in process_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@blasten
Copy link
Author

blasten commented Aug 6, 2019

cc @tvolkert @zanderso

@blasten blasten changed the title Windows space Fix: "ProcessException: %1 is not a valid Win32 application. Aug 6, 2019
@tvolkert tvolkert merged commit 8e9b03b into google:master Aug 6, 2019
@tvolkert
Copy link
Contributor

tvolkert commented Aug 6, 2019

I uploaded a new version to pub, so you should be all set to pull this into flutter. Thanks!

@blasten
Copy link
Author

blasten commented Aug 6, 2019

Awesome! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants