This repository has been archived by the owner on Dec 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ProcessManager signatures to be consistent with LocalProcessManag…
…er (#58) When `LocalProcessManager.run`, `.runSync`, and `.start` were migrated for null-safety, the base `ProcessManager` interface was not updated. This led to an inconsistency where the interface unnecessarily required non-null versions of `workingDirectory` and `environment`, which creates extra headache for clients. This change should be safe since it makes the base interface less restrictive. Additionally, `LocalProcessManager` takes a covariant `List<Object>` where the base interface takes `List<dynamic>`. I don't see a need for the interface to take `List<dynamic>` (which could accept `null`) so change that too. This change is less safe, although in practice anything that attempted to pass `null` would already crash if using the `LocalProcessManager` implementation anyway. Fixes #56.
- Loading branch information
1 parent
56ece43
commit 7ca6534
Showing
4 changed files
with
18 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters