-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid adding a redundant newline when printing weblistPageClosing #665
Avoid adding a redundant newline when printing weblistPageClosing #665
Conversation
This would otherwise be caught with the improved vet printf checker (golang/go#30436).
This would otherwise be caught with the improved vet printf checker (golang/go#30436).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate why is this change needed? What's wrong with Println?
If this is to avoid a redundant newline, then I think it's easier to update the value of the weblistPageClosing var to remove it there and leave the code as is. And also the PR description needs to be updated I think. I don't think this change has anything to do with the linked 'go vet' changes. Those changes are about format strings for Printf. |
Sounds good.
Yes, it is about avoiding a redundant new line. The reason I mentioned vet is because a previous limitation has been recently addressed. I will change the description. |
The description still mentions "go vet". |
Hopefully, I have corrected it at all the relevant places now. |
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 41 41
Lines 7391 7391
=======================================
Hits 5040 5040
Misses 1910 1910
Partials 441 441 Continue to review full report at Codecov.
|
weblistPageClosing string ends in a new line, so printing it via fmt.Println will add an extra new line.