Skip to content

Commit

Permalink
Add comments saying why we need cache directives
Browse files Browse the repository at this point in the history
  • Loading branch information
ghemawat committed Aug 27, 2024
1 parent 0366190 commit 0749233
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ jobs:
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
if: matrix.go != 'tip'
with:
# Include cache directives to allow proper caching. Without them, we
# get setup-go "Restore cache failed" warnings.
go-version: ${{ matrix.go }}
cache: true
cache-dependency-path: '**/go.sum'
Expand All @@ -46,6 +48,8 @@ jobs:
if: matrix.go == 'tip'
with:
# Bootstrapping go tip requires 1.22.6
# Include cache directives to allow proper caching. Without them, we
# get setup-go "Restore cache failed" warnings.
go-version: 1.22
cache: true
cache-dependency-path: '**/go.sum'
Expand Down Expand Up @@ -107,6 +111,8 @@ jobs:
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
if: matrix.go != 'tip'
with:
# Include cache directives to allow proper caching. Without them, we
# get setup-go "Restore cache failed" warnings.
go-version: ${{ matrix.go }}
cache: true
cache-dependency-path: '**/go.sum'
Expand All @@ -116,6 +122,8 @@ jobs:
if: matrix.go == 'tip'
with:
# Bootstrapping go tip requires 1.22.6
# Include cache directives to allow proper caching. Without them, we
# get setup-go "Restore cache failed" warnings.
go-version: 1.22
cache: true
cache-dependency-path: '**/go.sum'
Expand Down Expand Up @@ -171,6 +179,8 @@ jobs:
- name: Update Go version using setup-go
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
# Include cache directives to allow proper caching. Without them, we
# get setup-go "Restore cache failed" warnings.
go-version: ${{ matrix.go }}
cache: true
cache-dependency-path: '**/go.sum'
Expand Down

0 comments on commit 0749233

Please sign in to comment.