Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Drop support for Node 8 #111

Merged
merged 1 commit into from
Apr 7, 2020
Merged

chore!: Drop support for Node 8 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [8, 10, 12, 13]
node: [ 10, 12, 13]
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
Expand Down
21 changes: 9 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,20 @@
[pprof][pprof-url] support for Node.js.

## Prerequisites
1. Your application will need to be using Node.js 8.9.4 or greater, Node.js
10.4.1 or greater, or any version of Node 12. The profiler should not be
enabled when using earlier versions of Node 8 and 10 because the profiler is
not stable with those versions of Node.js.
* Versions of Node.js 8 prior to 8.9.4 are impacted by
[this](https://bugs.chromium.org/p/v8/issues/detail?id=6623) issue, which
causes a memory leak when time profiling is enabled.
* Versions of Node.js 10 prior to 10.4.1 are impacted by
[this](https://bugs.chromium.org/p/chromium/issues/detail?id=847863) issue,
which can cause garbage collection to take several minutes when heap
profiling is enabled.
1. Your application will need to be using Node.js 10.4.1 or greater, or any
version of Node 12.

The profiler should not be enabled when using earlier versions of Node 10,
since versions of Node.js 10 prior to 10.4.1 are impacted by
[this](https://bugs.chromium.org/p/chromium/issues/detail?id=847863) issue,
which can cause garbage collection to take several minutes when heap profiling
is enabled.

2. The `pprof` module has a native component that is used to collect profiles
with v8's CPU and Heap profilers. You may need to install additional
dependencies to build this module.
* For Linux: `pprof` has prebuilt binaries available for Linux and Alpine
Linux for Node 8, 10, 11 and 12. No additional dependencies are required.
Linux for Node 10, 11 and 12. No additional dependencies are required.
* For other environments: when using `@google-cloud/profiler` on environments
that `pprof` does not have prebuilt binaries for, the module
[`node-gyp`](https://www.npmjs.com/package/node-gyp) will be used to
Expand Down
14 changes: 0 additions & 14 deletions system-test/Dockerfile.node8-alpine
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions system-test/system_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if [[ "$RUN_ONLY_V8_CANARY_TEST" == "true" ]]; then
NVM_NODEJS_ORG_MIRROR="https://nodejs.org/download/v8-canary"
NODE_VERSIONS=(node)
else
NODE_VERSIONS=(8 10 11 12)
NODE_VERSIONS=(10 11 12)
fi

for i in ${NODE_VERSIONS[@]}; do
Expand All @@ -35,7 +35,7 @@ for i in ${NODE_VERSIONS[@]}; do

# Test support for accurate line numbers with node versions supporting this
# feature.
if [ "$i" != "8" ] && [ "$i" != "10" ] && [ "$i" != "11" ]; then
if [ "$i" != "10" ] && [ "$i" != "11" ]; then
docker run -v $PWD/..:/src -e BINARY_HOST="$BINARY_HOST" \
-e VERIFY_TIME_LINE_NUMBERS="true" node$i-linux \
/src/system-test/test.sh
Expand Down