fix(nvd-cve-osv): check for nil when logging VendorProduct
#2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkedar
requested review from
oliverchang,
andrewpollock,
hogo6002,
cuixq and
another-rex
cuixq
approved these changes
Oct 8, 2024
hogo6002
approved these changes
Oct 8, 2024
oliverchang
approved these changes
Oct 8, 2024
another-rex
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log line added in #2678 was causing a panic when
vpis nil (that we didn't notice 🤦).I believe it's causing processing to stop early, so we end up missing records and marking them as 'withdrawn' #2704
Also adding some checks elsewhere where vp might be dereferenced.
Also added the
-eflag to the run bash script so any other failures stop it from uploading (thanks @another-rex for pointing this out)