Further validate repos by only accepting ones with tags #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags are necessary for version resolution, and a repo without them is useless to us, and many of the repos in the current denylist do not have any tags.
The new and improved git.ValidRepo() reduces the maintenance burden of the denylist, as most of the repositories on it now fail validation.
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
May 27, 2024
present in the VendorProductToRepoMap (intentionally). This also means that CVEs for repos that lack tags but otherwise have a commit hash in the CVE's references now get excluded from consideration from conversion. CVE-2023-0327 before google#2233 had an entry in the VendorProductToRepoMap for `theradsystem_project:theradsystem`, even though the repo wasn't usable. Afterwards, it does not: ``` [CVE-2023-0327]: Failed to derive any repos for "theradsystem_project" "theradsystem" [CVE-2023-0327]: Summary: [CPEs=1 AppCPEs=1 DerivedRepos=0] [CVE-2023-0327]: Passing due to lack of viable repository ``` Add test coverage for `ReposFromReferences()` and fix a couple of bugs that it flushed out for when there is no VendorProductToRepoMap cache in use. Remove some unnecessary code stubs that aren't going to get filled out (the approach to determining CVE scope changed to trying them all, regardless of language)
andrewpollock
added a commit
that referenced
this pull request
May 28, 2024
#2233 introduced a small regression, in that repositories for CPEs that have no usable tags are no longer present in the VendorProductToRepoMap (intentionally). This also means that CVEs for these repos that lack tags but otherwise have a commit hash in the CVE's references now get excluded from consideration from conversion. CVE-2023-0327 before #2233 had an entry in the VendorProductToRepoMap for `theradsystem_project:theradsystem`, even though the repo wasn't usable. Afterwards, it does not, resulting in: ``` [CVE-2023-0327]: Failed to derive any repos for "theradsystem_project" "theradsystem" [CVE-2023-0327]: Summary: [CPEs=1 AppCPEs=1 DerivedRepos=0] [CVE-2023-0327]: Passing due to lack of viable repository ``` because of the added rigour of `cves.ValidRepo()` https://github.com/google/osv.dev/blob/7ab7d213d4daba3f0c65954b06c035aad5feb498/vulnfeeds/cmd/nvd-cve-osv/main.go#L248-L250 Add a less rigourous variation of repo validation that merely validates repo _existence_ for this last resort conversion attempt. Add test coverage for `ReposFromReferences()` and fix a couple of bugs that it flushed out for when there is no VendorProductToRepoMap cache in use. Remove some unnecessary code stubs that aren't going to get filled out (the approach to determining CVE scope changed to trying them all, regardless of language)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags are necessary for version resolution, and a repo without them is useless to us, and many of the repos in the current denylist do not have any tags.
This enables a radical simplification of the repo denylist and largely removes ongoing maintenance burden.
Latest run in Production:
Local test run:
A fabulous improvement in CVEsForKnownRepos, a much (durably) firmer looking denominator for conversion metrics.