Rename/unify CVE vulnfeed project #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IIRC, Cloud Deploy will make a new workload with the new name, but won't delete the old one with the original name, so that'll have to be manually deleted. |
michaelkedar
approved these changes
Jan 29, 2024
andrewpollock
requested changes
Jan 29, 2024
andrewpollock
approved these changes
Jan 30, 2024
Co-authored-by: Andrew Pollock <andrewpollock@users.noreply.github.com>
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Jan 30, 2024
Improve on the quick fix shoe-horned into PR google#1936 by restoring external configurability of the oldest desired year and biasing for the current and more recent years first (because Andrew hates delayed gratification)
andrewpollock
added a commit
that referenced
this pull request
Jan 30, 2024
Improve on the quick fix shoe-horned into PR #1936 by restoring external configurability of the oldest desired year and biasing for the current and more recent years first (because Andrew hates delayed gratification)
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Oct 17, 2024
This commit harmonizes the Cloud Logging log name with the previous naming tidy up done in google#1936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all the CVE vulnfeed project names into one name:
cpe-repo-gen.Currently the NVD cve vulnfeed project is two binaries with 5 different names (which was quite confusing to figure out when debugging):
cperepos(dir path: vulnfeeds/cmd/cperepos/)cpe-repo-gen(docker image name)gen-cperepos-map(yaml file name and kubernetes worker and container name)and the NVD to OSV conversion exe has:
cpp(dir path: vulnfeeds/cpp)nvd-cve-osv(image/kubernetes worker name)This PR unifies then down to two names,
cpe-repo-genandnvd-cve-osv. I also movednvd-cve-osvunder thecmd/directory since it's a binary (fromvulnfeeds/cpptovulnfeeds/cmd/nvd-cve-osv)I'm not sure if changing the worker name will require some manual work when deploying?