Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: downgrade codecov action to v3 #871

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 19, 2024

It seems that v4 is having some teething problems - coverage is no longer being uploaded due to the lack of a token, and it seems like at least some people are getting 500s even when they do provide a token (codecov/codecov-action#1248).

Let's start by downgrading to a known working version, and go from there.

Relates to #784

Before:

image

After:

image

v4 requires some changes to upgrade including setting up a token
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (b28c1c8) to head (01cb733).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   59.78%   61.18%   +1.39%     
==========================================
  Files         136      144       +8     
  Lines       11268    11808     +540     
==========================================
+ Hits         6737     7225     +488     
- Misses       4102     4110       +8     
- Partials      429      473      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex merged commit a90d443 into google:main Mar 19, 2024
12 checks passed
@G-Rath G-Rath deleted the downgrade-code-cov branch March 19, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants