Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-builder-new] Fix compile script. #6340

Merged
merged 1 commit into from
Aug 27, 2021
Merged

[base-builder-new] Fix compile script. #6340

merged 1 commit into from
Aug 27, 2021

Conversation

jonathanmetzman
Copy link
Contributor

In #6322 compile was synced
with the version in base-builder. However, base-builder's compile
assumes that rust and go are installed. This change makes it possible
to run compile without those installed.

In #6322 compile was synced
with the version in base-builder. However, base-builder's compile
assumes that rust and go are installed. This change makes it possible
to run compile without those installed.
@jonathanmetzman
Copy link
Contributor Author

TBR so I can continue splitting the images without blocking on this.

@jonathanmetzman jonathanmetzman merged commit 20858d3 into master Aug 27, 2021
@jonathanmetzman jonathanmetzman deleted the compile-fix branch August 27, 2021 20:00
Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants