[Ubuntu Upgrade][docs] Say need to build msan deps manually #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All dependencies must be built with MSAN by the project. OSS-Fuzz will not be providing any instrumented libraries. Related: #6180
jonathanmetzman
requested review from
oliverchang,
asraa,
inferno-chromium and
olivekl
jonathanmetzman
changed the title
jonathanmetzman
changed the title
jonathanmetzman
changed the title
jonathanmetzman
changed the title
oliverchang
approved these changes
Aug 17, 2021
| [msan-libs-builder Dockerfile](https://github.com/google/oss-fuzz/blob/master/infra/base-images/msan-libs-builder/Dockerfile#L20). | ||
| un-instrumented system dependencies. | ||
| If you want to use "memory," please build all libraries your project needs using | ||
| MemorySanitizer. |
There was a problem hiding this comment.
mention "and statically link them into the binary"?
There was a problem hiding this comment.
Why? We do support dynamic linking, I suspect this would work with msan too.
Maybe I should just omit this part you are suggesting. WDYT?
Change-Id: I5fffa344ebc1c696a3626442d8735efbefff0ef9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dependencies must be built with MSAN by the project.
OSS-Fuzz will not be providing any instrumented libraries.
Related: #6180